add regex validation #420
Merged
add regex validation #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adds regex validation for URL paths in the infinity_server.py file, enhancing the API's robustness and ensuring proper URL formatting.
- Added
validate_urlfunction inlibs/infinity_emb/infinity_emb/infinity_server.pyto validate URL paths using regex - Implemented regex pattern to ensure URL paths start with '/' and don't end with '/'
- Applied
validate_urlas a callback to theurl_prefixoption in thev2command - Added
CHECK_TYPER.mark_required()call in theclifunction for improved input validation
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
- Coverage 79.22% 79.13% -0.09%
==========================================
Files 40 40
Lines 3167 3173 +6
==========================================
+ Hits 2509 2511 +2
- Misses 658 662 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #418
This pull request to
libs/infinity_emb/infinity_emb/infinity_server.pyincludes changes to enhance URL validation and improve command-line interface behavior. The most important changes include adding a new URL validation function, integrating this validation into theurl_prefixoption, and ensuring required parameters are marked for the CLI.Enhancements to URL validation and CLI behavior:
libs/infinity_emb/infinity_emb/infinity_server.py: Imported theremodule to support regular expression operations.libs/infinity_emb/infinity_emb/infinity_server.py: Added thevalidate_urlfunction to ensure URL paths start with '/' and do not end with '/'.libs/infinity_emb/infinity_emb/infinity_server.py: Integrated thevalidate_urlfunction into theurl_prefixoption in thev2command to enforce URL validation.libs/infinity_emb/infinity_emb/infinity_server.py: Added a call toCHECK_TYPER.mark_required()in theclifunction to ensure required parameters are marked for the CLI.